[jira] [Commented] (ROCKETMQ-323) Release semaphore after callback being finished for async invoke

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ROCKETMQ-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279800#comment-16279800
 ] 

ASF GitHub Bot commented on ROCKETMQ-323:
-----------------------------------------

coveralls commented on issue #200: [ROCKETMQ-323] Release semaphore after 
callback being finished for async invoke
URL: https://github.com/apache/rocketmq/pull/200#issuecomment-349562165
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/14524419/badge)](https://coveralls.io/builds/14524419)
   
   Coverage decreased (-0.02%) to 39.241% when pulling 
**6c5a9507b4a2243c9a541bb325416502b2281dfb on zhouxinyu:ROCKETMQ-323** into 
**8c303104830afe53721fad231e671fc12670df8c on apache:develop**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Release semaphore after callback being finished for async invoke
> ----------------------------------------------------------------
>
>                 Key: ROCKETMQ-323
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-323
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>          Components: rocketmq-client
>    Affects Versions: 4.0.0-incubating, 4.1.0-incubating
>            Reporter: yukon
>            Assignee: yukon
>             Fix For: 4.2.0
>
>
> Currently, the async semaphore will be released before invoking the callback, 
> if the callback is a heavy task which is not recommended, lots of async 
> requests will be queued in `publicExecutor` thread pool, may cause OOM or FGC.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)