[
https://issues.apache.org/jira/browse/ROCKETMQ-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871077#comment-15871077
]
ASF GitHub Bot commented on ROCKETMQ-106:
-----------------------------------------
GitHub user Jaskey opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/66
[ROCKETMQ-106] Add flow control on topic level
https://issues.apache.org/jira/browse/ROCKETMQ-106
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jaskey/incubator-rocketmq
ROCKETMQ-106-topic-flow-control
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/66.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #66
----
commit 112e36cece57dea4c6f64eec8b2d5dbb46385bee
Author: Jaskey <linjunjie1...@gmail.com>
Date: 2017-02-17T02:42:54Z
Add flow control on topic level
----
> Add flow control on topic level
> -------------------------------
>
> Key: ROCKETMQ-106
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-106
> Project: Apache RocketMQ
> Issue Type: Wish
> Components: rocketmq-client
> Reporter: Jaskey Lam
> Assignee: Xiaorui Wang
>
> *Motivations*
> For current flow control, we can only control on queue level.
> Howerver, the numbers of queue allocated may be dynamic changed. For example,
> I might hope to control that at most 1000 messages can be pulled from broker
> to protect my client. And I have no idea how many queue I am allocated. Maybe
> I will have 5 queue and 5 instances so I set `pullThresholdForQueue`=1000,
> which works as expected when one is fine. But as long as any instances
> crashes, some instances may be allocated more than one queue, which will
> make messages pulled from broker exceed my expectations.
> A configuration of `pullThresholdForTopic` is propably most user hopes.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
