[ https://issues.apache.org/jira/browse/ROCKETMQ-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885183#comment-15885183 ]
ASF GitHub Bot commented on ROCKETMQ-106: ----------------------------------------- Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/66#discussion_r103139919 --- Diff: client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java --- @@ -166,11 +166,16 @@ private int consumeConcurrentlyMaxSpan = 2000; /** - * Flow control threshold + * Flow control threshold on queue level */ private int pullThresholdForQueue = 1000; /** + * Flow control threshold on topic level, should be greater or equals than pullThresholdForQueue + */ + private int pullThresholdForTopic = 2000; --- End diff -- Then the topic flow control will happen first, so no threadhold of queue will be reached > Add flow control on topic level > ------------------------------- > > Key: ROCKETMQ-106 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-106 > Project: Apache RocketMQ > Issue Type: Wish > Components: rocketmq-client > Reporter: Jaskey Lam > Assignee: Jaskey Lam > > *Motivations* > For current flow control, we can only control on queue level. > Howerver, the numbers of queue allocated may be dynamic changed. For example, > I might hope to control that at most 1000 messages can be pulled from broker > to protect my client. And I have no idea how many queue I am allocated. Maybe > I will have 5 queue and 5 instances so I set `pullThresholdForQueue`=1000, > which works as expected when one is fine. But as long as any instances > crashes, some instances may be allocated more than one queue, which will > make messages pulled from broker exceed my expectations. > A configuration of `pullThresholdForTopic` is propably most user hopes. -- This message was sent by Atlassian JIRA (v6.3.15#6346)