[ https://issues.apache.org/jira/browse/ROCKETMQ-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906907#comment-15906907 ]
ASF GitHub Bot commented on ROCKETMQ-96: ---------------------------------------- Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/60#discussion_r105594848 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java --- @@ -449,9 +449,9 @@ private SendResult sendDefaultImpl(// String[] brokersSent = new String[timesTotal]; for (; times < timesTotal; times++) { String lastBrokerName = null == mq ? null : mq.getBrokerName(); - MessageQueue tmpmq = this.selectOneMessageQueue(topicPublishInfo, lastBrokerName); - if (tmpmq != null) { - mq = tmpmq; + MessageQueue mqAttempt = this.selectOneMessageQueue(topicPublishInfo, lastBrokerName); --- End diff -- IMO , any variable named like XXXtmp is bad. Maybe we can rename it to another one but tmpMq is far from good enough > Rename tmp variable > -------------------- > > Key: ROCKETMQ-96 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-96 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-client > Affects Versions: 4.0.0-incubating > Reporter: Jaskey Lam > Assignee: Jaskey Lam > Priority: Minor > > Some variable is named with tmp which is very difficult to read and > understand its usage. > For exampe: > 1. in sendDefaultImpl, when select message queue, the variable is named with > > MessageQueue tmpmq = this.selectOneMessageQueue(topicPublishInfo, > lastBrokerName); > 2. In process queue, a field is named `msgTreeMapTemp`, which takes me > minutes to understand why it is desgined for, which should be rename to some > name like consumeingOrderlyMsgTreeMap -- This message was sent by Atlassian JIRA (v6.3.15#6346)