[ https://issues.apache.org/jira/browse/ROCKETMQ-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005971#comment-16005971 ]
ASF GitHub Bot commented on ROCKETMQ-96: ---------------------------------------- Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/60 [![Coverage Status](https://coveralls.io/builds/11470474/badge)](https://coveralls.io/builds/11470474) Coverage decreased (-0.05%) to 37.865% when pulling **ad82f0215e97bcad0b40379a6ba0b1a965b4d904 on Jaskey:ROCKETMQ-96** into **80aac138d905561c7a63c8e15fdfe60e958a3032 on apache:develop**. > Rename tmp variable > -------------------- > > Key: ROCKETMQ-96 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-96 > Project: Apache RocketMQ > Issue Type: Improvement > Components: rocketmq-client > Affects Versions: 4.0.0-incubating > Reporter: Jaskey Lam > Assignee: Jaskey Lam > Priority: Minor > Fix For: 4.1.0-incubating > > > Some variable is named with tmp which is very difficult to read and > understand its usage. > For exampe: > 1. in sendDefaultImpl, when select message queue, the variable is named with > > MessageQueue tmpmq = this.selectOneMessageQueue(topicPublishInfo, > lastBrokerName); > 2. In process queue, a field is named `msgTreeMapTemp`, which takes me > minutes to understand why it is desgined for, which should be rename to some > name like consumeingOrderlyMsgTreeMap -- This message was sent by Atlassian JIRA (v6.3.15#6346)