[ https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968560#comment-15968560 ]
ASF GitHub Bot commented on ROCKETMQ-174: ----------------------------------------- Github user Jaskey commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/91#discussion_r111525174 --- Diff: client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecutor.java --- @@ -18,6 +18,6 @@ import org.apache.rocketmq.common.message.Message; -public interface LocalTransactionExecuter { - public LocalTransactionState executeLocalTransactionBranch(final Message msg, final Object arg); +public interface LocalTransactionExecutor { --- End diff -- For cinfiguration issue, we can fix them by pointing them to the same right spelling config. private int rightConfig; @Deprecated public int getTypoConfig(){ return rightConfig; } @Deprecated public void setTypoConfig(int val) { this.rightConfig = val; } getter/setter for right config... But since client config and server config is working in tatolly different ways that server config uses reflection to load configurations so this should be only work for client configuration typo issue. I suggest we post another two typo issues for client configuration and server configuration. > Spelling Fix > ------------ > > Key: ROCKETMQ-174 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-174 > Project: Apache RocketMQ > Issue Type: Improvement > Reporter: Zhanhui Li > Assignee: Zhanhui Li > Priority: Trivial > Time Spent: 168h > Remaining Estimate: 0h > > Existing code base contains many spelling issues, this is to fix them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)