[ 
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002623#comment-16002623
 ] 

ASF GitHub Bot commented on ROCKETMQ-174:
-----------------------------------------

Github user vsair commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115478015
  
    --- Diff: 
common/src/main/java/org/apache/rocketmq/common/protocol/route/TopicRouteData.java
 ---
    @@ -27,23 +27,23 @@
     
     public class TopicRouteData extends RemotingSerializable {
         private String orderTopicConf;
    -    private List<QueueData> queueDatas;
    -    private List<BrokerData> brokerDatas;
    +    private List<QueueData> queueDataList;
    +    private List<BrokerData> brokerDataList;
    --- End diff --
    
    It is modification of protocol, IMO, it's improper for upgrade of server or 
client.


> Spelling Fix
> ------------
>
>                 Key: ROCKETMQ-174
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: Zhanhui Li
>            Assignee: Zhanhui Li
>            Priority: Trivial
>             Fix For: 4.1.0-incubating
>
>          Time Spent: 168h
>  Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to