[ https://issues.apache.org/jira/browse/ROCKETMQ-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073398#comment-16073398 ]
ASF GitHub Bot commented on ROCKETMQ-6: --------------------------------------- Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/3#discussion_r93904989 --- Diff: rocketmq-common/src/main/java/com/alibaba/rocketmq/common/MixAll.java --- @@ -287,8 +287,8 @@ public static void printObjectProperties(final Logger log, final Object object, } } - if (log != null) { - log.info(name + "=" + value); + if (logger != null) { + logger.info(name + "=" + value); --- End diff -- please replace {} with + :-) > Use logger for exceptions instead of e.printStackTrace() > -------------------------------------------------------- > > Key: ROCKETMQ-6 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-6 > Project: Apache RocketMQ > Issue Type: Improvement > Reporter: Roman Shtykh > Assignee: Roman Shtykh > Fix For: 4.2.0-incubating > > > Replace {{e.printStackTrace()}} with {{log.error(...)}} in all core modules, > except tests, tools and examples. -- This message was sent by Atlassian JIRA (v6.4.14#64029)