[
https://issues.apache.org/jira/browse/ROCKETMQ-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818088#comment-15818088
]
ASF GitHub Bot commented on ROCKETMQ-6:
---------------------------------------
Github user wu-sheng commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/3#discussion_r95562388
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/processor/PullMessageProcessor.java
---
@@ -87,8 +87,8 @@ private RemotingCommand processRequest(final Channel
channel, RemotingCommand re
response.setOpaque(request.getOpaque());
- if (LOG.isDebugEnabled()) {
- LOG.debug("receive PullMessage request command, {}", request);
+ if (log.isDebugEnabled()) {
--- End diff --
`log.isDebugEnabled()` is not necessary, and do not consistent with other
codes log-style.
> Use logger for exceptions instead of e.printStackTrace()
> --------------------------------------------------------
>
> Key: ROCKETMQ-6
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-6
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
> Fix For: 4.1.0-incubating
>
>
> Replace {{e.printStackTrace()}} with {{log.error(...)}} in all core modules,
> except tests, tools and examples.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
