cottage14 commented on PR #1235: URL: https://github.com/apache/royale-asjs/pull/1235#issuecomment-1733803960
If this gets committed, please provide full documentation for those who may use it after you. <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> Virus-free.www.avast.com <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> On Mon, Sep 25, 2023 at 10:32 AM Cristallium ***@***.***> wrote: > I just discovered new issue with BinaryUploader . > > With the fisrt fix, it can send real datas instead of "[object > ArrayBuffer]" . > This is working right with text files, but it's not working right with > some bytes. For exemple a file with 0xc0 inside will be wrong encoded by > the TextEncoder('utf8'). > To solve that as XMLHttpRequest can send typed array ( > https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Sending_and_Receiving_Binary_Data#sending_typed_arrays_as_binary_data), > there is no need to convert to utf8 string, > So sending this : > element.send(_binaryData.array); > instead of > element.send(binaryData); > will solve this other issue. > ------------------------------ > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/royale-asjs/pull/1235 > Commit Summary > > - 38a1eba > <https://github.com/apache/royale-asjs/pull/1235/commits/38a1eba5e8b80dec5b46a5f9456dabe02d4389a7> > Update BinaryUploader.as > - 22bed25 > <https://github.com/apache/royale-asjs/pull/1235/commits/22bed2564662c506cc227ee86a9001eed162de2a> > Fix POST data send by sending typedArray instead of utf8 string > > File Changes > > (1 file <https://github.com/apache/royale-asjs/pull/1235/files>) > > - *M* > frameworks/projects/Network/src/main/royale/org/apache/royale/net/BinaryUploader.as > <https://github.com/apache/royale-asjs/pull/1235/files#diff-9e9ee60ff4995626a8a356aae01e799fe921d458f277238058501985a916fd76> > (34) > > Patch Links: > > - https://github.com/apache/royale-asjs/pull/1235.patch > - https://github.com/apache/royale-asjs/pull/1235.diff > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/royale-asjs/pull/1235>, or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AC3RFXLVP2XZ4H2LNYXOAJLX4GBYNANCNFSM6AAAAAA5GDMOJM> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > -- Andrew Wetmore Editor, Moose House Publications <https://moosehousepress.com> Editor-Writer, The Apache Software Foundation <https://apache.org> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@royale.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
