cristallium commented on PR #1235: URL: https://github.com/apache/royale-asjs/pull/1235#issuecomment-1733861462
do you mean an example of how to use it ? Le 2023-09-25 16:17, Andrew Wetmore a écrit : > If this gets committed, please provide full documentation for those who > may > use it after you. > > <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> > Virus-free.www.avast.com > <https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> > <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> > > On Mon, Sep 25, 2023 at 10:32 AM Cristallium ***@***.***> > wrote: > >> I just discovered new issue with BinaryUploader . >> >> With the fisrt fix, it can send real datas instead of "[object >> ArrayBuffer]" . >> This is working right with text files, but it's not working right with >> some bytes. For exemple a file with 0xc0 inside will be wrong encoded >> by >> the TextEncoder('utf8'). >> To solve that as XMLHttpRequest can send typed array ( >> https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Sending_and_Receiving_Binary_Data#sending_typed_arrays_as_binary_data), >> there is no need to convert to utf8 string, >> So sending this : >> element.send(_binaryData.array); >> instead of >> element.send(binaryData); >> will solve this other issue. >> ------------------------------ >> You can view, comment on, or merge this pull request online at: >> >> https://github.com/apache/royale-asjs/pull/1235 >> Commit Summary >> >> - 38a1eba >> <https://github.com/apache/royale-asjs/pull/1235/commits/38a1eba5e8b80dec5b46a5f9456dabe02d4389a7> >> Update BinaryUploader.as >> - 22bed25 >> <https://github.com/apache/royale-asjs/pull/1235/commits/22bed2564662c506cc227ee86a9001eed162de2a> >> Fix POST data send by sending typedArray instead of utf8 string >> >> File Changes >> >> (1 file <https://github.com/apache/royale-asjs/pull/1235/files>) >> >> - *M* >> frameworks/projects/Network/src/main/royale/org/apache/royale/net/BinaryUploader.as >> <https://github.com/apache/royale-asjs/pull/1235/files#diff-9e9ee60ff4995626a8a356aae01e799fe921d458f277238058501985a916fd76> >> (34) >> >> Patch Links: >> >> - https://github.com/apache/royale-asjs/pull/1235.patch >> - https://github.com/apache/royale-asjs/pull/1235.diff >> >> -- >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/royale-asjs/pull/1235>, or unsubscribe >> <https://github.com/notifications/unsubscribe-auth/AC3RFXLVP2XZ4H2LNYXOAJLX4GBYNANCNFSM6AAAAAA5GDMOJM> >> . >> You are receiving this because you are subscribed to this >> thread.Message >> ID: ***@***.***> >> > > -- > Andrew Wetmore > > Editor, Moose House Publications <https://moosehousepress.com> > Editor-Writer, The Apache Software Foundation <https://apache.org> > -- > Reply to this email directly, view it on GitHub [1], or unsubscribe > [2]. > You are receiving this because you authored the thread.Message ID: > ***@***.***> - Links: ------ [1] https://github.com/apache/royale-asjs/pull/1235#issuecomment-1733803960 [2] https://github.com/notifications/unsubscribe-auth/ABUIW2IVHFPA2CGNQZYZ6K3X4GHABANCNFSM6AAAAAA5GDMOJM --=_8cc604faf880eaef99c652efd02fe632 Content-Type: multipart/related; boundary="=_5069e14e20ac233beac4a5c769fb604c" --=_5069e14e20ac233beac4a5c769fb604c Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; charset= =3DUTF-8" /></head><body style=3D'font-size: 10pt; font-family: Arial,Helve= tica,sans-serif'> <p>do you mean an example of how to use it ?</p> <p id=3D"reply-intro">Le 2023-09-25 16:17, Andrew Wetmore a écrit&nb= sp;:</p> <blockquote type=3D"cite" style=3D"padding: 0 0.4em; border-left: #1010ff 2= px solid; margin: 0"> <div id=3D"replybody1"> <p><br /></p> If this gets committed, please provide full documentation for those who may= <br />use it after you. <br /><br /><https://www.avast.com/sig-email?ut= m_medium=3Demail&utm_source=3Dlink&utm_campaign=3Dsig-email&utm= _content=3Dwebmail> <br />Virus-free.www.avast.com <br /><https://www= =2Eavast.com/sig-email?utm_medium=3Demail&utm_source=3Dlink&utm_cam= paign=3Dsig-email&utm_content=3Dwebmail> <br /><#DAB4FAD8-2DD7-40= BB-A1B8-4E2AA1F9FDF2> <br /><br />On Mon, Sep 25, 2023 at 10:32=E2=80=AF= AM Cristallium ***@***.***> <br />wrote: <br /><br />> I just discove= red new issue with BinaryUploader . <br />> <br />> With the fisrt fi= x, it can send real datas instead of "[object <br />> ArrayBuffer]" . <b= r />> This is working right with text files, but it's not working right = with <br />> some bytes. For exemple a file with 0xc0 inside will be wro= ng encoded by <br />> the TextEncoder('utf8'). <br />> To solve that = as XMLHttpRequest can send typed array ( <br />> https://developer.mozil= la.org/en-US/docs/Web/API/XMLHttpRequest/Sending_and_Receiving_Binary_Data#= sending_typed_arrays_as_binary_data), <br />> there is no need to conver= t to utf8 string, <br />> So sending this : <br />> element.send(_bin= aryData.array); <br />> instead of <br />> element.send(binaryData); = <br />> will solve this other issue. <br />> ------------------------= ------ <br />> You can view, comment on, or merge this pull request onli= ne at: <br />> <br />> https://github.com/apache/royale-asjs/pull/123= 5 <br />> Commit Summary <br />> <br />> - 38a1eba <br />> <= https://github.com/apache/royale-asjs/pull/1235/commits/38a1eba5e8b80dec5b4= 6a5f9456dabe02d4389a7> <br />> Update BinaryUploader.as <br />> - = 22bed25 <br />> <https://github.com/apache/royale-asjs/pull/1235/comm= its/22bed2564662c506cc227ee86a9001eed162de2a> <br />> Fix POST data s= end by sending typedArray instead of utf8 string <br />> <br />> File= Changes <br />> <br />> (1 file <https://github.com/apache/royale= -asjs/pull/1235/files>) <br />> <br />> - *M* <br />> framework= s/projects/Network/src/main/royale/org/apache/royale/net/BinaryUploader.as = <br />> <https://github.com/apache/royale-asjs/pull/1235/files#diff-9= e9ee60ff4995626a8a356aae01e799fe921d458f277238058501985a916fd76> <br />&= gt; (34) <br />> <br />> Patch Links: <br />> <br />> - https:/= /github.com/apache/royale-asjs/pull/1235.patch <br />> - https://github.= com/apache/royale-asjs/pull/1235.diff <br />> <br />> — <br />&= gt; Reply to this email directly, view it on GitHub <br />> <https://= github.com/apache/royale-asjs/pull/1235>, or unsubscribe <br />> <= https://github.com/notifications/unsubscribe-auth/AC3RFXLVP2XZ4H2LNYXOAJLX4= GBYNANCNFSM6AAAAAA5GDMOJM> <br />> . <br />> You are receiving thi= s because you are subscribed to this thread.Message <br />> ID: ***@***.= ***> <br />> <br /><br /><br />-- <br />Andrew Wetmore <br /><br />Ed= itor, Moose House Publications <https://moosehousepress.com> <br />Ed= itor-Writer, The Apache Software Foundation <https://apache.org> <br = /> <p style=3D"font-size: small; -webkit-text-size-adjust: none; color: #666;"= >—<br />Reply to this email directly, <a href=3D"https://github.com/a= pache/royale-asjs/pull/1235#issuecomment-1733803960" target=3D"_blank" rel= =3D"noopener noreferrer">view it on GitHub</a>, or <a href=3D"https://githu= b.com/notifications/unsubscribe-auth/ABUIW2IVHFPA2CGNQZYZ6K3X4GHABANCNFSM6A= AAAAA5GDMOJM" target=3D"_blank" rel=3D"noopener noreferrer">unsubscribe</a>= =2E<br />You are receiving this because you authored the thread.<img src=3D= ***@***.***" width=3D"1" height= =3D"1" /><span style=3D"color: transparent; font-size: 0; display: none; vi= sibility: hidden; overflow: hidden; opacity: 0; width: 0px; height: 0px; ma= x-width: 0; max-height: 0; mso-hide: all;">Message ID: <span><apache/roy= ale-asjs/pull/1235/c1733803960</span><span>@</span><span>github</span><span= >.</span><span>com></span></span></p> </div> </blockquote> <p><br /></p> <div id=3D"signature">- <pre> </pre> </div> </body></html> --=_5069e14e20ac233beac4a5c769fb604c Content-Transfer-Encoding: base64 Content-ID: ***@***.***> Content-Type: image/gif; name=blocked.gif Content-Disposition: inline; filename=blocked.gif; size=118 R0lGODlhZAAyAIAAAPrOzgAAACH5BAAAAAAALAAAAABkADIAAAJNhI+py+0Po5y02ouz3rz7D4bi SJbmiabqyrbuC8fyTNf2jef6zvf+DwwKh8Si8YhMKpfMpvMJjUqn1Kr1is1qt9yu9wsOi8fksvls KwAAOw== --=_5069e14e20ac233beac4a5c769fb604c-- --=_8cc604faf880eaef99c652efd02fe632-- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@royale.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
