[
https://issues.apache.org/jira/browse/SENTRY-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022062#comment-16022062
]
Alexander Kolbasov commented on SENTRY-1744:
--------------------------------------------
What is the benefit of providing configurable store? Here are some drawbacks:
1) This is over-engineered. Generic model is only provided and expected to work
with DelegateSentryStore, nothing else.
2) Having config-style generation makes things unnecessarily complicated and
difficult to verify - the assembly is happening at run time, so you can't
cross-reference at compile time well
3) Sentry is a security product, so the less configuration happens via config
files (especially in regards to dynamic loading of Java code) the easier it is
to understand and verify that it is safe and correct.
> Simplify creation of DelegateSentryStore
> ----------------------------------------
>
> Key: SENTRY-1744
> URL: https://issues.apache.org/jira/browse/SENTRY-1744
> Project: Sentry
> Issue Type: Improvement
> Components: Sentry
> Affects Versions: 1.8.0, sentry-ha-redesign
> Reporter: Alexander Kolbasov
> Assignee: Alexander Kolbasov
> Attachments: SENTRY-1744.001.patch
>
>
> It looks like we have a very "generic" code in SentryGenericPolicyProcessor
> that creates DelegateSentryStore based on the class name which may be changed
> in configuration. This is very cute, but sounds quite complicated to me. I
> don't know the history here, but I would suggest removing this and just
> creating DelegateSentryStore directly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
