[
https://issues.apache.org/jira/browse/SENTRY-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031842#comment-16031842
]
Sergio Peña commented on SENTRY-1744:
-------------------------------------
[~akolb] The patch looks good. I see this dynamic creation was introduced by
SENTRY-404. Have you pinged the developers to know more about why it is needed?
That patch is related to some solr/elasticsearch work.
> Simplify creation of DelegateSentryStore
> ----------------------------------------
>
> Key: SENTRY-1744
> URL: https://issues.apache.org/jira/browse/SENTRY-1744
> Project: Sentry
> Issue Type: Improvement
> Components: Sentry
> Affects Versions: 1.8.0, sentry-ha-redesign
> Reporter: Alexander Kolbasov
> Assignee: Alexander Kolbasov
> Attachments: SENTRY-1744.001.patch
>
>
> It looks like we have a very "generic" code in SentryGenericPolicyProcessor
> that creates DelegateSentryStore based on the class name which may be changed
> in configuration. This is very cute, but sounds quite complicated to me. I
> don't know the history here, but I would suggest removing this and just
> creating DelegateSentryStore directly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
