[ https://issues.apache.org/jira/browse/SENTRY-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105013#comment-16105013 ]
kalyan kumar kalvagadda commented on SENTRY-1839: ------------------------------------------------- [~coheig] With the changes done for SENTRY-1849 we haved fixed dependencies that were wrong. This brings in need to make additional code changes to build for hive-auth2 profile. These changes are in the common code that is used by both senty-binding-hive and sentry-binding-hive-v2 packages. Current change set is just first step towards that. I broke the effort for making the code properly build for V2 in to threee parts 1. SENTRY-1839 Duplicate file in sentry-binding-hive-common package 2. SENTRY-1843 Add sentry-binding-hive-follower-v2 package to support Hive 2.1.1 3. SENTRY-1847 Fix the compilation issues while building with hive-auth2 profile I did not want to do all of it in a single commit as it would be difficult to track and review the code changes. Once above three jira's are fixed code would be build for hive-auth2. > Copy files from sentry-binding-hive-common package to sentry-binding-hive and > sentry-binding-hive-v2 packages > ------------------------------------------------------------------------------------------------------------- > > Key: SENTRY-1839 > URL: https://issues.apache.org/jira/browse/SENTRY-1839 > Project: Sentry > Issue Type: Sub-task > Components: Sentry > Affects Versions: 2.0.0 > Reporter: kalyan kumar kalvagadda > Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-1839.001-sentry-ha-redesign.patch, > SENTRY-1839.002-sentry-ha-redesign.patch, > SENTRY-1839.003-sentry-ha-redesign.patch > > > Originally sentry-binding-hive-common was created by extracting common > classes binding-hive-v1 and binding-hive-v2(hive 2.0.0). With the changes > done to hive interface in 2.1.1 that is not the case. Below listed files need > different implementation. > # AuthorizingObjectStoreBase.java > # HiveAuthzBindingHookBase.java > # MetastoreAuthzBindingBase.java > # SentryHiveMetaStoreClient.java > # SentryMetastorePostEventListenerBase.java > Idea to copy a copy of these file to sentry-binding-hive and > sentry-binding-hive-v2 > packages so that they can have a separate implementation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)