[ 
https://issues.apache.org/jira/browse/SENTRY-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107168#comment-16107168
 ] 

kalyan kumar kalvagadda commented on SENTRY-1839:
-------------------------------------------------

we need to maintain support for both for Hive 1.1.0 and Hive 2.x until all the 
test failures with  2.x are properly handled. 
when we know support for 2.x is stable, we can change the default dependency on 
hive to Hive 2.x and eventually  remove support for hive 1.1.0.

When this happens we will not have duplicate code.

> Copy files from sentry-binding-hive-common package to sentry-binding-hive and 
> sentry-binding-hive-v2 packages
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: SENTRY-1839
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1839
>             Project: Sentry
>          Issue Type: Sub-task
>          Components: Sentry
>    Affects Versions: 2.0.0
>            Reporter: kalyan kumar kalvagadda
>            Assignee: kalyan kumar kalvagadda
>         Attachments: SENTRY-1839.001-sentry-ha-redesign.patch, 
> SENTRY-1839.002-sentry-ha-redesign.patch, 
> SENTRY-1839.003-sentry-ha-redesign.patch
>
>
> Originally sentry-binding-hive-common was created by extracting common 
> classes binding-hive-v1 and binding-hive-v2(hive 2.0.0). With the changes 
> done to hive interface in 2.1.1 that is not the case. Below listed files need 
> different implementation.
> # AuthorizingObjectStoreBase.java
> # HiveAuthzBindingHookBase.java
> # MetastoreAuthzBindingBase.java
> # SentryHiveMetaStoreClient.java
> # SentryMetastorePostEventListenerBase.java
> Idea to copy a copy of these file to sentry-binding-hive and 
> sentry-binding-hive-v2
> packages so that they can have a separate implementation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to