[
https://issues.apache.org/jira/browse/SENTRY-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246238#comment-16246238
]
Steve Moist commented on SENTRY-1662:
-------------------------------------
No particular reason, just new to all this. Saw the 1.8 in the affect version
and thought it needed to go there as well.
> Constants java uses mutable collection
> --------------------------------------
>
> Key: SENTRY-1662
> URL: https://issues.apache.org/jira/browse/SENTRY-1662
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
> Affects Versions: 1.8.0
> Reporter: Alexander Kolbasov
> Assignee: Steve Moist
> Priority: Minor
> Labels: bite-sized, newbie
> Fix For: 2.0.0
>
> Attachments: SENTRY-1662.001-branch1.8.patch, SENTRY-1662.001.patch
>
>
> Constants.java has the following code:
> {code}
> public static final Map<String, String> requestTypeToOperationMap = new
> HashMap<String, String>();
> public static final Map<String, String> requestTypeToObjectTypeMap = new
> HashMap<String, String>();
> static {
> // for hive audit log
> requestTypeToOperationMap.put(TCreateSentryRoleRequest.class.getName(),
> Constants.OPERATION_CREATE_ROLE);
> requestTypeToOperationMap.put(
> TAlterSentryRoleGrantPrivilegeRequest.class.getName(),
> Constants.OPERATION_GRANT_PRIVILEGE);
> ...
> {code}
> Instead it should create immutable maps for these.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
