[
https://issues.apache.org/jira/browse/SENTRY-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246582#comment-16246582
]
Hadoop QA commented on SENTRY-1662:
-----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12896931/SENTRY-1662.002.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/3432/console
This message is automatically generated.
> Constants java uses mutable collection
> --------------------------------------
>
> Key: SENTRY-1662
> URL: https://issues.apache.org/jira/browse/SENTRY-1662
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
> Affects Versions: 2.0.0
> Reporter: Alexander Kolbasov
> Assignee: Steve Moist
> Priority: Minor
> Labels: bite-sized, newbie
> Fix For: 2.0.0
>
> Attachments: SENTRY-1662.001.patch, SENTRY-1662.002.patch
>
>
> Constants.java has the following code:
> {code}
> public static final Map<String, String> requestTypeToOperationMap = new
> HashMap<String, String>();
> public static final Map<String, String> requestTypeToObjectTypeMap = new
> HashMap<String, String>();
> static {
> // for hive audit log
> requestTypeToOperationMap.put(TCreateSentryRoleRequest.class.getName(),
> Constants.OPERATION_CREATE_ROLE);
> requestTypeToOperationMap.put(
> TAlterSentryRoleGrantPrivilegeRequest.class.getName(),
> Constants.OPERATION_GRANT_PRIVILEGE);
> ...
> {code}
> Instead it should create immutable maps for these.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
