[
https://issues.apache.org/jira/browse/SENTRY-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511801#comment-16511801
]
Alexander Kolbasov commented on SENTRY-2269:
--------------------------------------------
[~fahdsiddiqui] I see some problems with the proposal as you describe it. What
happens now is
# There is a new SentryStore API
# The API is exposed to unspecified components outside of Sentry
This means that the API becomes essentially public (it was completely private
to Sentry before) and developers who want to modify the API now must be
concerned with breaking something that doesn't live in the same repository.
That's why I am asking how this affects stability of SentryStore API.
[~kkalyan] What alternative implementations do you have in mind? Part of my
question was whether such alternative implementation(s) would be provided as
well and whether it would live in Sentry code base or it is up to users to
design such alternative implementations in which case this is a rather bad idea
since we can't guarantee any interface stability.
> Make SentryStore pluggable
> --------------------------
>
> Key: SENTRY-2269
> URL: https://issues.apache.org/jira/browse/SENTRY-2269
> Project: Sentry
> Issue Type: Improvement
> Components: sentrystore
> Affects Versions: 2.1.0
> Reporter: Fahd Siddiqui
> Assignee: Fahd Siddiqui
> Priority: Major
> Attachments: SENTRY-2269.1.patch
>
>
> Make SentryStore pluggable so a different implementation can be plugged in at
> run-time using a config property ("sentry.service.sentrystore"), similar to
> what we have for processor factories.
> This would entail extracting all public methods of SentryStore to a
> SentryStoreInterface and converting all call sites to program to the
> interface.
> It will default to the existing SentryStore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
