[
https://issues.apache.org/jira/browse/SENTRY-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517651#comment-16517651
]
Alexander Kolbasov commented on SENTRY-2269:
--------------------------------------------
Comment for the actual code change. In this case SentryStore *is* the interface
and existing SentryStore is an implementation so I would argue that instead of
creating {{SentryStoreInterface}} and having {{SentryStore}} as its
implementation it should be another way around.
Please also add a disclaimer that we are free to change/modify the interface at
any time and will break any client using it outside of Sentry code base.
> Make SentryStore pluggable
> --------------------------
>
> Key: SENTRY-2269
> URL: https://issues.apache.org/jira/browse/SENTRY-2269
> Project: Sentry
> Issue Type: Improvement
> Components: sentrystore
> Affects Versions: 2.1.0
> Reporter: Fahd Siddiqui
> Assignee: Fahd Siddiqui
> Priority: Major
> Attachments: SENTRY-2269.1.patch
>
>
> Make SentryStore pluggable so a different implementation can be plugged in at
> run-time using a config property ("sentry.service.sentrystore"), similar to
> what we have for processor factories.
> This would entail extracting all public methods of SentryStore to a
> SentryStoreInterface and converting all call sites to program to the
> interface.
> It will default to the existing SentryStore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
