[
https://issues.apache.org/jira/browse/SCB-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315317#comment-16315317
]
ASF GitHub Bot commented on SCB-85:
-----------------------------------
wujimin commented on a change in pull request #476: [SCB-85] Upgrade Metrics
File Output from 0.5.0 to 1.0.0-m1
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r160050978
##########
File path:
samples/springmvc-sample/springmvc-provider/src/main/java/io/servicecomb/samples/springmvc/provider/SpringmvcHelloImpl.java
##########
@@ -73,7 +74,7 @@ public String metricsForTest() {
try {
Review comment:
why not return Map<String, String>
each time you write JsonUtils.writeValueAsString to be a schema operation
result, you need think if you have make something wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1
> --------------------------------------------------
>
> Key: SCB-85
> URL: https://issues.apache.org/jira/browse/SCB-85
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Fix For: java-chassis-1.0.0-m1
>
>
> Because metrics had complete reflected in 1.0.0-m1,so we need upgrade file
> output example and show new features.
> 1.support more build-in metric
> 2.support output operation level metric
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
