[
https://issues.apache.org/jira/browse/SCB-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315554#comment-16315554
]
ASF GitHub Bot commented on SCB-85:
-----------------------------------
zhengyangyong commented on a change in pull request #476: [SCB-85] Upgrade
Metrics File Output from 0.5.0 to 1.0.0-m1
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/476#discussion_r160066976
##########
File path:
foundations/foundation-metrics/src/main/java/io/servicecomb/foundation/metrics/MetricsServoRegistry.java
##########
@@ -563,7 +563,7 @@ public String getValue() {
}
private double round(double value, int places) {
- if (!Double.isNaN(value) && !Double.isInfinite(value)) {
+ if (!Double.isNaN(value)) {
BigDecimal decimal = new BigDecimal(value);
return decimal.setScale(places, RoundingMode.HALF_UP).doubleValue();
} else {
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade Metrics File Output from 0.5.0 to 1.0.0-m1
> --------------------------------------------------
>
> Key: SCB-85
> URL: https://issues.apache.org/jira/browse/SCB-85
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Fix For: java-chassis-1.0.0-m1
>
>
> Because metrics had complete reflected in 1.0.0-m1,so we need upgrade file
> output example and show new features.
> 1.support more build-in metric
> 2.support output operation level metric
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
