[
https://issues.apache.org/jira/browse/SCB-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429625#comment-16429625
]
ASF GitHub Bot commented on SCB-459:
------------------------------------
WillemJiang commented on a change in pull request #637: [SCB-459]Update netty's
version to 4.1.19 and vertx's version to 3.5.1
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/637#discussion_r179934986
##########
File path: java-chassis-dependencies/pom.xml
##########
@@ -32,7 +32,7 @@
<properties>
<jackson.version>2.9.4</jackson.version>
- <vertx.version>3.5.0</vertx.version>
Review comment:
Please update the License file for the update.
We need to update the NOTICE file as vertx 3.5.1 updated its NOTICE file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update netty's version to 4.1.19 and vertx's version to 3.5.1
> -------------------------------------------------------------
>
> Key: SCB-459
> URL: https://issues.apache.org/jira/browse/SCB-459
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
> Affects Versions: service-center-1.0.0-m2
> Reporter: xuyiyun
> Assignee: xuyiyun
> Priority: Major
> Fix For: service-center-1.0.0-m2
>
>
> h3. {color:#333333}{{1.Vertx fix thread-safety of
> RouteImpl：[https://github.com/vert-x3/vertx-web/pull/739]}}{color}
> h3. {color:#333333}{{2.Vertx 3.5.1 supporting netty 4.1.19, solved the
> problem of domain name resolution，do not need to configure ndots.}}{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
