[
https://issues.apache.org/jira/browse/SCB-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429657#comment-16429657
]
ASF GitHub Bot commented on SCB-459:
------------------------------------
liubao68 commented on a change in pull request #637: [SCB-459]Update netty's
version to 4.1.19 and vertx's version to 3.5.1
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/637#discussion_r179938539
##########
File path:
foundations/foundation-vertx/src/test/java/org/apache/servicecomb/foundation/vertx/TestVertxTLSBuilder.java
##########
@@ -49,7 +49,7 @@ public void testbuildHttpServerOptions() {
SSLCustom custom = SSLCustom.createSSLCustom(option.getSslCustomClass());
HttpServerOptions serverOptions = new HttpServerOptions();
VertxTLSBuilder.buildNetServerOptions(option, custom, serverOptions);
-
Assert.assertEquals(serverOptions.getEnabledSecureTransportProtocols().toArray().length,
1);
+
Assert.assertEquals(serverOptions.getEnabledSecureTransportProtocols().toArray().length,
3);
Review comment:
Why this has been changed? We need only enable TLS1.2+ only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update netty's version to 4.1.19 and vertx's version to 3.5.1
> -------------------------------------------------------------
>
> Key: SCB-459
> URL: https://issues.apache.org/jira/browse/SCB-459
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
> Affects Versions: service-center-1.0.0-m2
> Reporter: xuyiyun
> Assignee: xuyiyun
> Priority: Major
> Fix For: service-center-1.0.0-m2
>
>
> h3. {color:#333333}{{1.Vertx fix thread-safety of
> RouteImpl：[https://github.com/vert-x3/vertx-web/pull/739]}}{color}
> h3. {color:#333333}{{2.Vertx 3.5.1 supporting netty 4.1.19, solved the
> problem of domain name resolution，do not need to configure ndots.}}{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
