[
https://issues.apache.org/jira/browse/SCB-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461131#comment-16461131
]
ASF GitHub Bot commented on SCB-504:
------------------------------------
wujimin commented on a change in pull request #673: [SCB-504] upgrade spring
boot version
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/673#discussion_r185525951
##########
File path:
integration-tests/spring-zuul-tracing-tests/src/test/java/org/apache/servicecomb/spring/cloud/zuul/tracing/SpringCloudZuulTracingTest.java
##########
@@ -82,15 +82,18 @@ public void tracesCallsReceivedFromZuulToCalledService()
throws InterruptedExcep
@Test
public void tracesFailedCallsReceivedByZuul() throws InterruptedException {
ResponseEntity<String> responseEntity =
testRestTemplate.getForEntity("/dummy/rest/oops", String.class);
-
- assertThat(responseEntity.getStatusCode(), is(INTERNAL_SERVER_ERROR));
-
+ try {
+ int code = responseEntity.getStatusCode().value();
+ assertThat(code, is(590));
+ expectFailing(IllegalArgumentException.class);
+ } catch (Exception ignore) {
Review comment:
why catch and eat Exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade to Spring boot 1.5.12.RELEASE
> -------------------------------------
>
> Key: SCB-504
> URL: https://issues.apache.org/jira/browse/SCB-504
> Project: Apache ServiceComb
> Issue Type: Wish
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m2
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> https://github.com/apache/incubator-servicecomb-java-chassis/issues/654
> we may test upgrade to 1.5.12.RELEASE
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
