[
https://issues.apache.org/jira/browse/SCB-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461881#comment-16461881
]
ASF GitHub Bot commented on SCB-504:
------------------------------------
zhengyangyong commented on a change in pull request #673: [SCB-504] upgrade
spring boot version
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/673#discussion_r185690617
##########
File path:
integration-tests/springmvc-tests/src/test/java/org/apache/servicecomb/demo/springmvc/tests/SpringMvcIntegrationTestBase.java
##########
@@ -637,14 +628,8 @@ public void ensureServerWorksFine() throws Exception {
@Test
public void ensureServerBlowsUp() {
- try {
- restTemplate.getForObject(
- controllerUrl + "sayhi?name=throwexception",
- String.class);
- fail("Exception expected, but threw nothing");
- } catch (UnknownHttpStatusCodeException e) {
- assertThat(e.getRawStatusCode(), is(590));
- }
+ String response = restTemplate.getForObject(controllerUrl +
"sayhi?name=throwexception", String.class);
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade to Spring boot 1.5.12.RELEASE
> -------------------------------------
>
> Key: SCB-504
> URL: https://issues.apache.org/jira/browse/SCB-504
> Project: Apache ServiceComb
> Issue Type: Wish
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m2
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> https://github.com/apache/incubator-servicecomb-java-chassis/issues/654
> we may test upgrade to 1.5.12.RELEASE
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
