[ https://issues.apache.org/jira/browse/SCB-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462107#comment-16462107 ]
ASF GitHub Bot commented on SCB-504: ------------------------------------ wujimin commented on a change in pull request #673: [SCB-504] upgrade spring boot version URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/673#discussion_r185727540 ########## File path: integration-tests/springmvc-tests/src/test/java/org/apache/servicecomb/demo/springmvc/tests/SpringMvcIntegrationTestBase.java ########## @@ -329,14 +325,10 @@ public void blowsUpWhenFileNameDoesNotMatch() throws Exception { HttpHeaders headers = new HttpHeaders(); headers.setContentType(MediaType.MULTIPART_FORM_DATA); - try { - restTemplate.postForObject( - codeFirstUrl + "uploadWithoutAnnotation", - new HttpEntity<>(map, headers), - String.class); - expectFailing(UnknownHttpStatusCodeException.class); - } catch (RestClientException ignored) { - } + ResponseEntity<String> response = restTemplate + .postForEntity(codeFirstUrl + "uploadWithoutAnnotation", new HttpEntity<>(map, headers), String.class); + assertThat(response.getStatusCodeValue(), is(response.getStatusCodeValue())); Review comment: self equals self? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade to Spring boot 1.5.12.RELEASE > ------------------------------------- > > Key: SCB-504 > URL: https://issues.apache.org/jira/browse/SCB-504 > Project: Apache ServiceComb > Issue Type: Wish > Components: Java-Chassis > Affects Versions: java-chassis-1.0.0-m2 > Reporter: yangyongzheng > Assignee: yangyongzheng > Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > https://github.com/apache/incubator-servicecomb-java-chassis/issues/654 > we may test upgrade to 1.5.12.RELEASE -- This message was sent by Atlassian JIRA (v7.6.3#76005)