[
https://issues.apache.org/jira/browse/SCB-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492088#comment-16492088
]
ASF GitHub Bot commented on SCB-589:
------------------------------------
wujimin commented on a change in pull request #728: [SCB-589] Consumer
producer upgrade unordered
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/728#discussion_r191082099
##########
File path:
core/src/main/java/org/apache/servicecomb/core/provider/consumer/InvokerUtils.java
##########
@@ -35,31 +33,37 @@
private static final Logger LOGGER =
LoggerFactory.getLogger(InvokerUtils.class);
public static Object syncInvoke(String microserviceName, String schemaId,
String operationName, Object[] args) {
- checkEngineStatus();
- ReferenceConfig referenceConfig =
CseContext.getInstance().getConsumerProviderManager()
- .getReferenceConfig(microserviceName);
+ ReferenceConfig referenceConfig =
SCBEngine.getInstance().getReferenceConfigForInvoke(microserviceName);
return syncInvoke(generateInvocation(schemaId, operationName, args,
referenceConfig));
}
public static Object syncInvoke(String microserviceName, String
microserviceVersion, String transport,
String schemaId, String operationName, Object[] args) {
- checkEngineStatus();
- ReferenceConfig referenceConfig =
CseContext.getInstance().getConsumerProviderManager()
- .createReferenceConfig(microserviceName, microserviceVersion,
transport);
+ ReferenceConfig referenceConfig = SCBEngine.getInstance()
+ .createReferenceConfigForInvoke(microserviceName, microserviceVersion,
transport);
return syncInvoke(generateInvocation(schemaId, operationName, args,
referenceConfig));
}
+ /**
+ * it's a internal API, caller make sure already invoked
SCBEngine.ensureStatusUp
+ * @param invocation
+ * @return
+ * @throws InvocationException
+ */
public static Object syncInvoke(Invocation invocation) throws
InvocationException {
- checkEngineStatus();
Response response = innerSyncInvoke(invocation);
if (response.isSuccessed()) {
return response.getResult();
}
throw ExceptionFactory.convertConsumerException(response.getResult());
}
+ /**
+ * it's a internal API, caller make sure already invoked
SCBEngine.ensureStatusUp
+ * @param invocation
+ * @return
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> allow consumer upgrade before producer
> --------------------------------------
>
> Key: SCB-589
> URL: https://issues.apache.org/jira/browse/SCB-589
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: wujimin
> Priority: Major
>
> 1.normal consumer use PrivateMicroserviceClassLoaderFactory, just like edge
> 2.consumer microserviceMeta will not save in microserviceMetaManager any
> more, just like edge, use appManager; and change consumer default versionRule
> from latest to all
> 3.allow consumer schema set or method set bigger than contract
> 4.protobuf dynamic class created in microservice classloader
> 5.seems that can delete MicroserviceMetaManager
> 6.edge remains task should be finished:
> https://issues.apache.org/jira/browse/SCB-279
>
> jackson hold classes by a LRU map, will not always hold class, so there is no
> big problems.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
