[
https://issues.apache.org/jira/browse/SCB-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492230#comment-16492230
]
ASF GitHub Bot commented on SCB-589:
------------------------------------
WillemJiang commented on a change in pull request #728: [SCB-589] Consumer
producer upgrade unordered
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/728#discussion_r191101947
##########
File path:
common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/definition/ProtobufManager.java
##########
@@ -37,6 +39,9 @@
private static final Object LOCK = new Object();
+ private static ScopedProtobufSchemaManager
defaultScopedProtobufSchemaManager = new ScopedProtobufSchemaManager(
Review comment:
It could cause some trouble as the schema manager's class loader cannot be
changed after the static initial time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> allow consumer upgrade before producer
> --------------------------------------
>
> Key: SCB-589
> URL: https://issues.apache.org/jira/browse/SCB-589
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: wujimin
> Priority: Major
>
> 1.normal consumer use PrivateMicroserviceClassLoaderFactory, just like edge
> 2.consumer microserviceMeta will not save in microserviceMetaManager any
> more, just like edge, use appManager; and change consumer default versionRule
> from latest to all
> 3.allow consumer schema set or method set bigger than contract
> 4.protobuf dynamic class created in microservice classloader
> 5.seems that can delete MicroserviceMetaManager
> 6.edge remains task should be finished:
> https://issues.apache.org/jira/browse/SCB-279
>
> jackson hold classes by a LRU map, will not always hold class, so there is no
> big problems.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
