[
https://issues.apache.org/jira/browse/SCB-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617271#comment-16617271
]
ASF GitHub Bot commented on SCB-915:
------------------------------------
oliugian commented on a change in pull request #299: SCB-915:saga alpha event
scanner optimization
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/299#discussion_r217994961
##########
File path:
alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/CompositeOmegaCallbackRunner.java
##########
@@ -20,30 +20,44 @@
import static java.util.Collections.emptyMap;
import java.lang.invoke.MethodHandles;
+import java.util.ArrayList;
+import java.util.List;
import java.util.Map;
+import java.util.concurrent.Callable;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class CompositeOmegaCallback implements OmegaCallback {
+public class CompositeOmegaCallbackRunner implements OmegaCallback,
Callable<List<TxEvent>> {
Review comment:
Compensate Thread ， using by PushBackOmegaCallback . PushBackOmegaCallback
will filter all compensate event by there service name ,do all compensate event
list with the same service name in one CompositeOmegaCallbackRunner thread
and only return those compensate events which are successful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> saga alpha event scanner optimization
> -------------------------------------
>
> Key: SCB-915
> URL: https://issues.apache.org/jira/browse/SCB-915
> Project: Apache ServiceComb
> Issue Type: Improvement
> Reporter: FuChenGeng
> Assignee: FuChenGeng
> Priority: Major
>
> 1.the compensate logic for retry scenarios is not perfect, in some place it
> do not considering retry scenarios.
> 2.do one compensation in one event scanner cycle,it mean that if there are
> 1000 aborted event, it will cost at lest 500s to compensate it. And it has
> some bugs like
> [https://github.com/apache/incubator-servicecomb-saga/issues/253]
> 3.all hot and cold data are in the same table
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
