[
https://issues.apache.org/jira/browse/SCB-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617278#comment-16617278
]
ASF GitHub Bot commented on SCB-915:
------------------------------------
oliugian commented on a change in pull request #299: SCB-915:saga alpha event
scanner optimization
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/299#discussion_r217996731
##########
File path:
alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/EventScanner.java
##########
@@ -79,58 +79,66 @@ private void pollEvents() {
scheduler.scheduleWithFixedDelay(
() -> {
updateTimeoutStatus();
- findTimeoutEvents();
+ findAllTimeoutEvents();
abortTimeoutEvents();
saveUncompensatedEventsToCommands();
compensate();
updateCompensatedCommands();
+ markSagaEndedForNoTxEnd();
Review comment:
for these transaction:
saga_start->tx_start->tx_abort->tx_abort
we need to add a saga_end behind them ,so we can judge them finish.
for dumping finished transactions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> saga alpha event scanner optimization
> -------------------------------------
>
> Key: SCB-915
> URL: https://issues.apache.org/jira/browse/SCB-915
> Project: Apache ServiceComb
> Issue Type: Improvement
> Reporter: FuChenGeng
> Assignee: FuChenGeng
> Priority: Major
>
> 1.the compensate logic for retry scenarios is not perfect, in some place it
> do not considering retry scenarios.
> 2.do one compensation in one event scanner cycle,it mean that if there are
> 1000 aborted event, it will cost at lest 500s to compensate it. And it has
> some bugs like
> [https://github.com/apache/incubator-servicecomb-saga/issues/253]
> 3.all hot and cold data are in the same table
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
