[
https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628631#comment-16628631
]
ASF GitHub Bot commented on SCB-925:
------------------------------------
liubao68 commented on a change in pull request #914: [SCB-925] Springmvc, when
have defaultValue, required should be false
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/914#discussion_r220527456
##########
File path:
integration-tests/springmvc-tests/springmvc-tests-common/src/test/java/org/apache/servicecomb/demo/springmvc/tests/endpoints/CodeFirstSpringmvcSimplifiedMappingAnnotation.java
##########
@@ -101,7 +101,7 @@ public String fileUpload(@RequestPart(name = "file1")
MultipartFile file1,
@PostMapping(path = "/uploadWithoutAnnotation", produces =
MediaType.TEXT_PLAIN_VALUE)
public String fileUploadWithoutAnnotation(MultipartFile file1, MultipartFile
file2,
- @RequestAttribute("name") String name) {
+ @RequestAttribute(name = "name", required = false) String name) {
Review comment:
Do we have test cases that name is null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Springmvc, when have defaultValue, required should be false
> -----------------------------------------------------------
>
> Key: SCB-925
> URL: https://issues.apache.org/jira/browse/SCB-925
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Reporter: WeiChao
> Assignee: WeiChao
> Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
