[
https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629598#comment-16629598
]
ASF GitHub Bot commented on SCB-925:
------------------------------------
wujimin commented on a change in pull request #914: [SCB-925] Springmvc, when
have defaultValue, required should be false
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/914#discussion_r220767774
##########
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/PathProcessorCreator.java
##########
@@ -36,8 +36,8 @@
public static final String PARAMTYPE = "path";
public static class PathProcessor extends AbstractParamProcessor {
- public PathProcessor(String paramPath, JavaType targetType, Object
defaultValue) {
- super(paramPath, targetType, defaultValue);
+ public PathProcessor(String paramPath, boolean required, JavaType
targetType, Object defaultValue) {
+ super(paramPath, required, targetType, defaultValue);
Review comment:
path parameter must be required, can not be null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Springmvc, when have defaultValue, required should be false
> -----------------------------------------------------------
>
> Key: SCB-925
> URL: https://issues.apache.org/jira/browse/SCB-925
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Reporter: WeiChao
> Assignee: WeiChao
> Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
