[
https://issues.apache.org/jira/browse/SCB-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629622#comment-16629622
]
ASF GitHub Bot commented on SCB-925:
------------------------------------
liubao68 commented on a change in pull request #914: [SCB-925] Springmvc, when
have defaultValue, required should be false
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/914#discussion_r220770416
##########
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/CookieProcessorCreator.java
##########
@@ -51,6 +53,9 @@ public Object getValue(HttpServletRequest request) throws
Exception {
if (paramPath.equals(cookie.getName())) {
value = cookie.getValue();
if (value == null) {
+ if (isRequired()) {
Review comment:
This is a logic that easily missed. Please add integration tests for this
condition when you finish.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Springmvc, when have defaultValue, required should be false
> -----------------------------------------------------------
>
> Key: SCB-925
> URL: https://issues.apache.org/jira/browse/SCB-925
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Reporter: WeiChao
> Assignee: WeiChao
> Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
