desruisseaux commented on code in PR #40:
URL: https://github.com/apache/sis/pull/40#discussion_r2792368655
##########
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java:
##########
@@ -59,6 +62,21 @@ final class ClientFileSystem extends FileSystem {
*/
final String accessKey;
+ /**
+ * The S3 host (if not stored on Amazon Infrastructure), or {@code null}
if none.
+ */
+ final String host;
+
+ /**
+ * The S3 port (if not stored on Amazon Infrastructure), or {@code null}
if none.
+ */
+ final Integer port;
+
+ /**
+ * Is the S3 HTTP Protocol secure (if not stored on Amazon Infrastructure)
(default {@code true)}.
+ */
+ boolean isHttps = true;
Review Comment:
It seems that this field can be final (move initialization to `true` insde
the constructor).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
