desruisseaux commented on code in PR #40:
URL: https://github.com/apache/sis/pull/40#discussion_r2792416345
##########
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystemKey.java:
##########
@@ -0,0 +1,111 @@
+package org.apache.sis.cloud.aws.s3;
+
+import java.util.Objects;
+
+/**
+ * File System Key stored in {@link FileService#fileSystems},
+ *
+ * @author Quentin Bialota (Geomatys)
+ */
+public class ClientFileSystemKey {
Review Comment:
Does it needs to be public? Try to keep it package private and final.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
