HoustonPutman commented on pull request #249: URL: https://github.com/apache/solr-operator/pull/249#issuecomment-813464072
There were surprisingly few pain points overall. I do think it would be great to make a common library/program. I think for the Operator's purposes, there could be settings fields in the yaml, that would allow for the python program to be completely generic. I don't even think I had to make changes beyond changing settings in the python code, and the branch versioning stuff (which is kind of hacky now, because `main` is the "stable" branch, there is no `v0.*` branch). There is a large gap between Lucene/Solr and the Solr Operator (go vs java, ant vs Makefile), so I think this would certainly be able to work for a lot of other Apache projects, requiring very little changes. But I think having a library & basic implementation would be perfect. That would allow for more complex project to add integrations with things like gradle/maven/etc, but also allow easier projects to onboard without having to write python code. The only custom code the Solr Operator would need vs Lucene/Solr is branch naming and versions starting with `v`. But maybe we just have variables in the YAML that regex, or fill in branch name templates. Lots of options that don't require code changes. Sorry if that's too stream-of-consciousness, but overall I think this would be great to put into a separate project so that other projects can incorporate it easier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
