HoustonPutman commented on pull request #249: URL: https://github.com/apache/solr-operator/pull/249#issuecomment-814469901
Thanks for finding those! For step 3.3, I agree that it's not a great place to have to download dependencies, but the dependencies might (and eventually will) be different depending on the branch you are on. If someone is making last minute fixes to the branch, it is definitely possible to bump up a version of kustomize, controller-gen or kubebuilder. Therefore we definitely want that to be in the loop of "Pull the branch and make sure that it is good". The rest are addressed. I have also added 1 feature to the releaseWizard.py so far, which is pretty small, let a command have it's own ENV set, independent of the other commands it is with. This is necessary for the `In releaseWizard.yaml line 693, jinja2 moustache are not expanded` issue you pointed out. Pretty small change overall though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
