[
https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331620#comment-17331620
]
Dawid Weiss commented on SOLR-15361:
------------------------------------
Sorry for the delay, I was away.
> I guess i'm missundertsanindg the javadocs of TaskInputs.property then ... i
> thought the point of the 'value' param was to set a default that would be
> cached (for he 'up to date' check) in place of the property value in the
> event the property wasn't set.
inputs.property(key, value) associates a string key-value pair with the task
input state. If this state changes, the task will be considered not up-to-date
and will be forced to re-run. If the key-value is the same (in the absence of
other inputs and outputs, simplifying a bit), the task will be up-to-date and
skipped.
For the signing task the inputs should logically be the input file to be signed
and the key you use for signing. The signing plugin very likely makes the input
file an input already (implicitly) and registers the output as well.
> Ok ... i can change that, but FWIW the reason i explicitly used
> gradle.taskGraph.whenReady instead of a doFirst was so that if
> failUnlessGpgKeyProperty was in the taskGraph the build would fail ASAP after
> configuration – before any unrelated tasks in the graph started executing.
I'm sorry then - it does work the way you wrote it. I didn't understand the
intention here.
> update gradle build to support gpg signing of tgz/zip distributions
> -------------------------------------------------------------------
>
> Key: SOLR-15361
> URL: https://issues.apache.org/jira/browse/SOLR-15361
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Fix For: main (9.0)
>
> Attachments: SOLR-15361.patch, SOLR-15361.patch, SOLR-15361.patch,
> SOLR-15361.patch
>
>
> the gradle build does not currently have any support for gpg signing the
> distributions we produce.
> this is neccessary for releases, and for being able to "smoke test" our
> Dockerfiles prior to release (by creating mock download servers to confirm
> {{docker build}} can correctly fetch the {{tgz}} & {{tgz.asc}} files we point
> it at)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
