dsmiley commented on a change in pull request #115:
URL: https://github.com/apache/solr/pull/115#discussion_r633896158
##########
File path: solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java
##########
@@ -533,10 +533,23 @@ public void doFilter(ServletRequest _request,
ServletResponse _response, FilterC
if (accepted) {
rateLimitManager.decrementActiveRequests(request);
}
+ span.setTag(Tags.HTTP_STATUS, response.getStatus());
span.finish();
}
}
-
+
+ protected Span buildSpan(HttpServletRequest request, Tracer tracer) {
+ return tracer
+ .buildSpan(
+ "http.request") // will be changed later
+ .asChildOf(tracer.extract(Format.Builtin.HTTP_HEADERS, new
HttpServletCarrier(request)))
+ .withTag(Tags.SPAN_KIND, Tags.SPAN_KIND_SERVER)
+ .withTag(Tags.HTTP_METHOD, request.getMethod())
Review comment:
I think you are observing from the diff that the span operation name
used to include the host & port. Those are poor choices for a span operation
name, and this PR expressly sets out to improve this. They weren't in
dedicated tags, although HTTP_URL includes them if we're curious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
