dsmiley commented on a change in pull request #115:
URL: https://github.com/apache/solr/pull/115#discussion_r634454291
##########
File path: solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java
##########
@@ -499,6 +495,7 @@ public void doFilter(ServletRequest _request,
ServletResponse _response, FilterC
if (log.isDebugEnabled()) {
log.debug("User principal: {}", request.getUserPrincipal());
}
+ span.setTag(Tags.DB_USER, String.valueOf(request.getUserPrincipal()));
Review comment:
If Auth is enabled but the user isn't authenticated, getUserPrincipal()
will return null and then String.valueOf will yield "null". I don't think we
should add this header if there is no auth because the header is then
inapplicable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
