dsmiley commented on a change in pull request #129: URL: https://github.com/apache/solr/pull/129#discussion_r634850011
########## File path: solr/core/src/java/org/apache/solr/parser/SolrQueryParserBase.java ########## @@ -1149,18 +1151,21 @@ protected Query getFieldQuery(String field, List<String> queryTerms, boolean raw return newFieldQuery (getAnalyzer(), field, queryText, false, fieldAutoGenPhraseQueries, fieldEnableGraphQueries, synonymQueryStyle); } else { - if (raw) { + if (raw) {// assumption: raw = false only when called from ExtendedDismaxQueryParser.getQuery() return new RawQuery(sf, queryTerms); } else { if (queryTerms.size() == 1) { return ft.getFieldQuery(parser, sf, queryTerms.get(0)); + } else if(ft instanceof StrField){ + String queryText = String.join(" ", queryTerms); + return ft.getFieldQuery(parser, sf, queryText); } else { List<Query> subqs = new ArrayList<>(); for (String queryTerm : queryTerms) { try { subqs.add(ft.getFieldQuery(parser, sf, queryTerm)); - } catch (Exception e) { // assumption: raw = false only when called from ExtendedDismaxQueryParser.getQuery() - // for edismax: ignore parsing failures + } catch (Exception e) { Review comment: I feel a comment is needed here. Do we know of particular exceptions where this happens (if so give an example in the comment) or is this more of a general safety fallback? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org