tomglk commented on pull request #123: URL: https://github.com/apache/solr/pull/123#issuecomment-848072975
Hi @cpoerschke! :) > My conclusion was that for back compat reasons the docValues would need to match stored fields behaviour -- _I will add a commit with proposed changes shortly_ -- and that what looks like a "string" value in the implementation is for "boolean" values only really i.e. F/0 and T/1 and when number values are required a number field type would/should be used instead. I just had the time to look through your changes. Although I liked the possibility to also handle numbers that are present in a string field, I agree that one should use a numeric field for that. One shouldn't expect the code to handle such cases. I think your changes made the functionalities that are supported much cleaner. And the consistent behavior between dv and non-dv fields also is a very important point that I admittedly paid not enough attention to. Thanks for keeping an eye on such things! > _And advance apologies, the commit has multiple things in one commit though I've tried to at least describe in the commit message details what is in it._ No worries, I read you notes in the commit while looking through the code and had no problem with understanding your thoughts behind the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
