cpoerschke commented on a change in pull request #151:
URL: https://github.com/apache/solr/pull/151#discussion_r646035979
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java
##########
@@ -999,20 +1013,34 @@ protected void mergeIds(ResponseBuilder rb, ShardRequest
sreq) {
shardDoc.sortFieldValues = unmarshalledSortFieldValues;
- queue.insertWithOverflow(shardDoc);
+ if(reRankQueue != null && docCounter++ <= reRankDocsSize) {
+ ShardDoc droppedShardDoc =
reRankQueue.insertWithOverflow(shardDoc);
+ // FIXME: Only works if the original request does not sort by
score
Review comment:
> ... I have no idea when 8.9 may be released. ... Do you have any
information on this? Maybe just a broad timeframe like 2 weeks / 2 months? ...
As per
https://lists.apache.org/thread.html/rc9b83cd6c1608088365a911b40fa98f0775a00b21ae1491725d63ebc%40%3Cdev.lucene.apache.org%3E
the 8.9 release process is now underway and from the "Release Lucene/Solr
8.9.0 should we have it soon" mailing list thread subject i.e.
https://lists.apache.org/thread.html/r6bde6e242a0801a63386dc3b7efb10d77038271cd9c69dc07f9c76a1%40%3Cdev.lucene.apache.org%3E
my understanding is that this is for both Lucene and Solr.
I hope that's not a disappointment, perhaps I could have provided more
clarity w.r.t. likely 8.9 timelines earlier here, sorry!
Perhaps "we are targetting 8.10" rather than "we just missed 8.9" could be
another way to look at it?
w.r.t. broad timeframe for 8.10 (assuming there will be a 8.10 before 9.0)
-- i don't know but historically e.g.
http://archive.apache.org/dist/lucene/solr/ usually there's a release every
couple of months but it depends (we have documentation on this somewhere which
explains it better but i can't find it right now). hope that helps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
