cpoerschke commented on a change in pull request #151:
URL: https://github.com/apache/solr/pull/151#discussion_r654965223



##########
File path: 
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java
##########
@@ -185,6 +187,8 @@ public void prepare(ResponseBuilder rb) throws IOException
         if(rq instanceof RankQuery) {
           RankQuery rankQuery = (RankQuery)rq;
           rb.setRankQuery(rankQuery);
+          // we always need the score for reRanking
+          rb.setFieldFlags(rb.getFieldFlags() | GET_SCORES);

Review comment:
       
https://github.com/apache/solr/pull/151/commits/909a25d59b826839dd34f4b1495b966913c95d3c
 proposes to continue to have only one `setFieldFlags` call




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to