tomglk commented on a change in pull request #166:
URL: https://github.com/apache/solr/pull/166#discussion_r646152833
##########
File path:
solr/contrib/ltr/src/test-files/solr/collection1/conf/solrconfig-ltr.xml
##########
@@ -34,6 +34,8 @@
initialSize="2048" autowarmCount="0" />
<cache name="QUERY_DOC_FV" class="solr.search.CaffeineCache" size="4096"
initialSize="2048" autowarmCount="4096"
regenerator="solr.search.NoOpRegenerator" />
+ <!-- false is the default, just here to make it explizit in contrast to
solrconfig-ltr-lazy-->
+ <enableLazyFieldLoading>false</enableLazyFieldLoading>
Review comment:
> is the enableLazyFieldLoading value the only difference between the
solrconfig-ltr.xml and solrconfig-ltr-lazy.xml files?
Yes, and I do not see any more differences coming in the future.
I parameterized it like you suggested, this saves us a lot of unnecessary
duplication. ( 0e55556 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
