tomglk commented on a change in pull request #166:
URL: https://github.com/apache/solr/pull/166#discussion_r646156988
##########
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java
##########
@@ -166,33 +166,36 @@ public float score() throws IOException {
try {
final Document document = context.reader().document(itr.docID(),
fieldAsSet);
- final IndexableField indexableField = document.getField(field);
- if (indexableField == null) {
- return getDefaultValue();
- }
- final Number number = indexableField.numericValue();
- if (number != null) {
- return number.floatValue();
- } else {
- final String string = indexableField.stringValue();
- if (string.length() == 1) {
- // boolean values in the index are encoded with the
- // a single char contained in TRUE_TOKEN or FALSE_TOKEN
- // (see BoolField)
- if (string.charAt(0) == BoolField.TRUE_TOKEN[0]) {
- return 1;
- }
- if (string.charAt(0) == BoolField.FALSE_TOKEN[0]) {
- return 0;
- }
- }
- }
+ return parseStoredFieldValue(document.getField(field));
} catch (final IOException e) {
throw new FeatureException(
e.toString() + ": " +
"Unable to extract feature for "
+ name, e);
}
+ }
+
+ float parseStoredFieldValue(IndexableField indexableField) throws
IOException {
Review comment:
ab81d8b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
