madrob commented on a change in pull request #162:
URL: https://github.com/apache/solr/pull/162#discussion_r646774159
##########
File path:
solr/contrib/jaegertracer-configurator/src/test/org/apache/solr/jaeger/TestJaegerConfigurator.java
##########
@@ -37,8 +36,7 @@
public class TestJaegerConfigurator extends SolrTestCaseJ4 {
- @Rule
- public TestRule solrTestRules = new SystemPropertiesRestoreRule();
+ @Rule public TestRule solrTestRules = new SystemPropertiesRestoreRule();
Review comment:
Is this option configurable?
##########
File path:
solr/contrib/jaegertracer-configurator/src/test/org/apache/solr/jaeger/TestJaegerConfigurator.java
##########
@@ -53,26 +51,23 @@ public void doBefore() {
@Test
public void testInjected() throws Exception {
- MiniSolrCloudCluster cluster = new SolrCloudTestCase.Builder(2,
createTempDir())
- .addConfig("config",
TEST_PATH().resolve("collection1").resolve("conf"))
- .withSolrXml(getFile("solr/solr.xml").toPath())
- .build();
+ MiniSolrCloudCluster cluster =
+ new SolrCloudTestCase.Builder(2, createTempDir())
+ .addConfig("config",
TEST_PATH().resolve("collection1").resolve("conf"))
+ .withSolrXml(getFile("solr/solr.xml").toPath())
+ .build();
try {
TimeOut timeOut = new TimeOut(2, TimeUnit.MINUTES, TimeSource.NANO_TIME);
timeOut.waitFor(
"Waiting for GlobalTracer is registered",
() -> GlobalTracer.get().toString().contains("JaegerTracer"));
- //TODO add run Jaeger through Docker and verify spans available after
run these commands
+ // TODO add run Jaeger through Docker and verify spans available after
run these commands
CollectionAdminRequest.createCollection("test", 2,
1).process(cluster.getSolrClient());
- new UpdateRequest()
- .add("id", "1")
- .add("id", "2")
- .process(cluster.getSolrClient(), "test");
+ new UpdateRequest().add("id", "1").add("id",
"2").process(cluster.getSolrClient(), "test");
Review comment:
I'm not sure I agree with this reformatting. How are the rules
configured for overrides? This is a minor nit, and if it's the only issue then
I'll deal with all of it on one line, but I'd like to understand more about the
plugin we're applying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
