cpoerschke commented on a change in pull request #162:
URL: https://github.com/apache/solr/pull/162#discussion_r650094150
##########
File path:
solr/contrib/jaegertracer-configurator/src/java/org/apache/solr/jaeger/JaegerTracerConfigurator.java
##########
@@ -31,7 +31,5 @@ public Tracer getTracer() {
}
@Override
- public void init(@SuppressWarnings({"rawtypes"})NamedList args) {
- }
-
+ public void init(@SuppressWarnings({"rawtypes"}) NamedList args) {}
Review comment:
> This conflict with one of the changes I made, it's easy to resolve
though, just delete everything!
Good catch! I assume #169 are the other changes. Would you like to proceed
with that pull request first or would you prefer this PR here be merged first?
Either approach would work for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
