thelabdude opened a new pull request #168:
URL: https://github.com/apache/solr/pull/168


   https://issues.apache.org/jira/browse/SOLR-15451
   
   # Description
   
   When executing a SQL statement, Solr needs to hit the `/admin/luke` endpoint 
(for a specific collection). This PR executes that request in a background 
"server" thread that uses the PKI principal (instead of the principal for the 
user that initiated the SQL request).
   
   # Solution
   
   Pretty straight-forward solution to run the request in a background thread 
that is marked as server thread, so the PKI principal is used. I also added a 
check for 403 in the `LBSolrClient` error handling to propagate authz-related 
errors directly instead of reporting "No live servers available to service this 
request".
   
   # Tests
   
   Added a unit test that executes a SQL statement as a user that does not have 
explicit access to the `/admin/luke` endpoint to verify the SQL can be executed 
successfully.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [ ] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [ ] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to