thelabdude commented on a change in pull request #168:
URL: https://github.com/apache/solr/pull/168#discussion_r649504387
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java
##########
@@ -217,6 +217,15 @@ public synchronized String nextOrError(Exception
previousEx) throws SolrServerEx
if (numServersTried > 0 && isTimeExceeded(timeAllowedNano, timeOutTime))
{
throw new SolrServerException("Time allowed to handle this request
exceeded"+suffix, previousEx);
}
+
+ // is authz related error
+ if (previousEx instanceof BaseHttpSolrClient.RemoteSolrException) {
+ BaseHttpSolrClient.RemoteSolrException rse =
(BaseHttpSolrClient.RemoteSolrException)previousEx;
+ if (rse.code() == 403) {
+ throw new SolrServerException(previousEx.getMessage(), previousEx);
+ }
+ }
Review comment:
I'll revert this change, now that I fixed the LukeRequest issue, we're
not hitting this code anyway. I think there's a problem here that should be
improved but should be done as a separate change. For now it has no impact on
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
